Bug fix #215 #216
Closed
Bug fix #215 #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @wind-tech-fun thank you! Are you able to also upgrade the CDN for font-awesome to the latest so that we can use the latest icons? |
| OK! I will open a new issues and pull request that upgrade the font awesome to version 6. And issue NO.215 and related pull request only for font awesome version 5. |
| I got time to look more at this. We are using front awesome v6.5. The correct font to use is fa-solid not fas. |
| OK!!! I will try to replace font awesome cdn version 5 to 6. Please ignore this bug fix, thanks : ) |
| Please help me close this PR. Thanks maintainer : ) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #215