Skip to content

Conversation

chonton
Copy link
Contributor

@chonton chonton commented Feb 23, 2020

No description provided.

@chonton
Copy link
Contributor Author

chonton commented Feb 25, 2020

What other information do you need?

@reda-alaoui
Copy link
Member

reda-alaoui commented Feb 25, 2020

Seems to me that includedModules and excludedModules achieve the same goal?

An answer to the question above :)

@chonton
Copy link
Contributor Author

chonton commented Feb 25, 2020

<excludedModules>*</excludedModules> could achieve the same behavior for all goals except install-hook

Consider the situation where I inherit a corporate pom that turns on this plugin's goals and I need to turn off one of the goals in my project. This will require re-configuration of the plugin in my project (or setting the excludedModules property in <properties>.)

When turning off a plugin, I look for a skip parameter which most plugins offer.

@reda-alaoui
Copy link
Member

Please resolve the conflict so we can merge this 👍

@chonton
Copy link
Contributor Author

chonton commented Feb 26, 2020

Done

@reda-alaoui
Copy link
Member

I am still seeing a merge conflict

@chonton
Copy link
Contributor Author

chonton commented Feb 27, 2020

really done

@reda-alaoui reda-alaoui merged commit 852c328 into Cosium:master Feb 27, 2020
@reda-alaoui
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants