Fix #31 windows install-hooks error #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thank you @mattruel ! |
| No problem, thank you for the quick merge! Some other ideas for improving this looking for existence of mvn.cmd, will see if it continues to give anyone trouble. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On windows machine install-hooks fails with this error:
[ERROR] Failed to execute goal com.cosium.code:maven-git-code-format:1.38:install-hooks (install-formatter-hook) on project xyz: java.io.IOException: Cannot run program "C:...\maven\bin\mvn": CreateProcess error=193, %1 is not a valid Win32 application
This fixes the error by looking for mvn.cmd instead of mvn if OS is windows.