Miscellaneous code improvements #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace call to deprecated method DigestUtils#shaHex(InputStream) by call to method DigestUtils#sha1Hex(InputStream)
Replace call to deprecated method ImportOrderer#reorderImports(String) by call to method ImportOrderer#reorderImports(String, Style)
| Hello @duke1995 , I don't agree with many Sonar default rules. Therefore I can't accept this change. |
No problem, @reda-alaoui , thank you for merging my other pull requests. About this particular pull request, It contained 5 separate commits for different possible issues. If there are any changes you would like me to make anyway, you can let me know, and I'll do a new pull request with only those changes. Thank you for the plugin, it's of great use to our development team. Kind regards |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This branch contains quick fixes for some Java problems which were reported by my IDE (Visual Studio Code with the SonarLint extension).