Bring snippets up to WordPress coding standards. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jtsternberg reviewed Apr 13, 2017
| add_filter( "sanitize_option_genesis-cpt-archive-settings-{$this->post_type}", array( | ||
| $this, | ||
| 'add_sanitized_values', | ||
| ), 999 ); |
Member
There was a problem hiding this comment.
not sure how the sniffer missed this, but callback arrays should not be split to multiple lines.
Contributor Author
There was a problem hiding this comment.
Yep, I'll revert this.
| // Get it started | ||
| // myprefix_genesis_cpt_settings( 'custom-post-type-slug' ); | ||
| // Get it started. | ||
| //myprefix_genesis_cpt_settings( 'custom-post-type-slug' ); |
Member
There was a problem hiding this comment.
I'm not a fan of //comments w/o space
Contributor Author
There was a problem hiding this comment.
Okay, I'll revert this change.
Member
| Thank you sir! |
Contributor Author
| No, thank you! This will be a great resource for Genesis folks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Just some minor formatting adjustments to bring the snippets inline with WordPress Coding Standards.