Skip to content

Conversation

narukami894
Copy link

Hello, thank you for creating nice app and import tool!
I fixed json_generator.rb to build boostnote.json as same as Boostnote itself by using JSON.pretty_generate, and replace the order of json keys.

before:

{"folders":[{"key":"xxxx","name":"myFolderName","color":"#B013A4"},{"key":"yyyy","name":"myFolderName2","color":"#FF8E00"},(...)],"version":"1.0"} 

after:

{ "folders": [ { "key": "xxxx", "color": "#3FD941", "name": "myFolderName" }, { "key": "yyyy", "color": "#2BA5F7", "name": "myFolderName2" }, (...) ], "version": "1.0" } 
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @narukami894. Sorry for my long absence and thank you very much for your improvement!
LGTM

@asmsuechan
Copy link
Contributor

GOSH. I don't have merge authorization...

@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 23, 2018

Excuse me, @Rokt33r. Will you please merge opening 2 PRs and remove this line

- 2.0.0
?

The reason why I tried to support even Ruby2.0 is that because it's pre-installed version of Ruby on macOS. So I'd say it's not good to remove compatibility with it.

@Rokt33r
Copy link
Member

Rokt33r commented Mar 23, 2018

@asmsuechan I've invited you as an admin to this repository. Check your e-mail. 😄

@IssueHuntBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants