types: relax model<T> type signature to allow any schema #15683
Closed
+22 −2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #15681
Summary
Something in 8.19.0 release started causing the following script to OOM crash:
I haven't been able to figure out exactly what, but there are two easy fixes:
const schema = new mongoose.Schema<T>(...)model<T>to take inSchema<any>as opposed toSchema<T>(2) seems reasonable to do, although we will also suggest (1). These fixes unfortunately seem to be exclusive - applying (2) makes (1) fail with OOM :(
Examples