Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(461)

Issue 218064: code review 218064: Updated to include items in $GOROOT/test/rename.go (exc...

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by ajstarks
Modified:
15 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

Updated to include items in $GOROOT/test/rename.go (except panic, panicln, print, println)

Patch Set 1 #

Patch Set 2 : code review 218064: Updated to include items in $GOROOT/test/rename.go (exc... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M misc/bbedit/Go.plist View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 4
ajstarks
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 8 months ago (2010-02-23 01:35:48 UTC) #1
rsc
I think you might have misunderstood my point in showing you rename.go. They're not reserved ...
15 years, 8 months ago (2010-02-23 01:41:36 UTC) #2
rsc
LGTM okay, as long as you understand that they're not reserved words
15 years, 8 months ago (2010-02-23 21:46:33 UTC) #3
rsc
15 years, 8 months ago (2010-02-23 21:50:55 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=877df558d370 *** misc/bbedit: treat predeclared identifiers as "keywords" R=rsc CC=golang-dev http://codereview.appspot.com/218064 Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b