Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(853)

Issue 1671043: Call git update-index --refresh in git-cl

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by thakis
Modified:
15 years, 3 months ago
Reviewers:
chase, evan, M-A
Visibility:
Public.

Description

To lighten your support burden.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M git-cl View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
thakis
15 years, 4 months ago (2010-06-24 01:08:09 UTC) #1
evan
LGTM http://codereview.appspot.com/1671043/diff/1/2 File git-cl (right): http://codereview.appspot.com/1671043/diff/1/2#newcode606 git-cl:606: if RunGit(['diff-index', 'HEAD']): this one too i think
15 years, 4 months ago (2010-06-24 01:11:11 UTC) #2
thakis
Do I check this in somewhere, or do you do the rest? http://codereview.appspot.com/1671043/diff/1/2 File git-cl ...
15 years, 4 months ago (2010-06-24 01:14:34 UTC) #3
evan
m-a knows how to check in
15 years, 4 months ago (2010-06-24 01:30:15 UTC) #4
M-A
If you have commit access to chromium os, git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git git fetch ...
15 years, 4 months ago (2010-06-25 02:03:57 UTC) #5
thakis
I don't have commit access. Use git Cl dcommit -c thakis :-p On Jun 24, ...
15 years, 4 months ago (2010-06-25 02:05:54 UTC) #6
thakis
M-A, say, did you still not land this?
15 years, 3 months ago (2010-07-16 18:48:49 UTC) #7
M-A
On 2010/07/16 18:48:49, thakis wrote: > M-A, say, did you still not land this? I ...
15 years, 3 months ago (2010-07-18 14:28:38 UTC) #8
chase
15 years, 3 months ago (2010-08-02 17:03:09 UTC) #9
On 2010/07/18 14:28:38, M-A wrote: > On 2010/07/16 18:48:49, thakis wrote: > > M-A, say, did you still not land this? > > I had forgot, done. http://codereview.appspot.com/1671043 adds the update-index --refresh call to SendUpstream, as well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b