LGTM http://codereview.appspot.com/1671043/diff/1/2 File git-cl (right): http://codereview.appspot.com/1671043/diff/1/2#newcode606 git-cl:606: if RunGit(['diff-index', 'HEAD']): this one too i think
15 years, 4 months ago (2010-06-24 01:11:11 UTC) #2
If you have commit access to chromium os, git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git git fetch ...
15 years, 4 months ago (2010-06-25 02:03:57 UTC) #5
If you have commit access to chromium os, git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git git fetch main (then hack your .git/config to switch the upstream branch to main, maybe Evan knows the actual git command) git cl push otherwise I can commit it but I prefer proper commit attribution when possible.
I don't have commit access. Use git Cl dcommit -c thakis :-p On Jun 24, ...
15 years, 4 months ago (2010-06-25 02:05:54 UTC) #6
I don't have commit access. Use git Cl dcommit -c thakis :-p On Jun 24, 2010 7:04 PM, <maruel@chromium.org> wrote: > If you have commit access to chromium os, > > git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git > git fetch main > (then hack your .git/config to switch the upstream branch to main, maybe > Evan knows the actual git command) > git cl push > > otherwise I can commit it but I prefer proper commit attribution when > possible. > > http://codereview.appspot.com/1671043/show
On 2010/07/18 14:28:38, M-A wrote: > On 2010/07/16 18:48:49, thakis wrote: > > M-A, say, ...
15 years, 3 months ago (2010-08-02 17:03:09 UTC) #9
On 2010/07/18 14:28:38, M-A wrote: > On 2010/07/16 18:48:49, thakis wrote: > > M-A, say, did you still not land this? > > I had forgot, done. http://codereview.appspot.com/1671043 adds the update-index --refresh call to SendUpstream, as well.
Issue 1671043: Call git update-index --refresh in git-cl Created 15 years, 4 months ago by thakis Modified 15 years, 3 months ago Reviewers: evan, M-A, chase Base URL: Comments: 2