Issue 135010043: Cleaned up v8 log importer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 135010043: Cleaned up v8 log importer.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by Sujeet Gholap

Modified:
11 years, 2 months ago

Reviewers:
nduca

CC:
trace-viewer-review_googlegroups.com, fmeawad

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Cleaned up v8 log importer. - Killed dead code - Killed CodeEntry.kind - Got rid of unnecessary arguments for processCodeCreateEvent_ (The whole cleanup proposal: https://docs.google.com/a/chromium.org/document/d/14ucTC18h8ZlHAk1WTeaIMI3AzJQwZW2BIBkyGnWrNBk/edit?usp=sharing ) R=nduca@chromium.org CC=fmeawad@chromium.org

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -19 lines)			Patch
	M	trace_viewer/tracing/importer/v8/log_reader.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	trace_viewer/tracing/importer/v8_log_importer.html	View		3 chunks	+2 lines, -19 lines	0 comments	Download