Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 135010043: Cleaned up v8 log importer.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Sujeet Gholap
Modified:
11 years, 2 months ago
Reviewers:
nduca
CC:
trace-viewer-review_googlegroups.com, fmeawad
Base URL:
http://trace-viewer.googlecode.com/svn/trunk
Visibility:
Public.

Description

Cleaned up v8 log importer. - Killed dead code - Killed CodeEntry.kind - Got rid of unnecessary arguments for processCodeCreateEvent_ (The whole cleanup proposal: https://docs.google.com/a/chromium.org/document/d/14ucTC18h8ZlHAk1WTeaIMI3AzJQwZW2BIBkyGnWrNBk/edit?usp=sharing ) R=nduca@chromium.org CC=fmeawad@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M trace_viewer/tracing/importer/v8/log_reader.html View 1 chunk +5 lines, -0 lines 0 comments Download
M trace_viewer/tracing/importer/v8_log_importer.html View 3 chunks +2 lines, -19 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b