Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Unified Diff: trace_viewer/tracing/importer/v8_log_importer.html

Issue 135010043: Cleaned up v8 log importer. Base URL: http://trace-viewer.googlecode.com/svn/trunk
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trace_viewer/tracing/importer/v8/log_reader.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trace_viewer/tracing/importer/v8_log_importer.html
diff --git a/trace_viewer/tracing/importer/v8_log_importer.html b/trace_viewer/tracing/importer/v8_log_importer.html
index d7331e6a38a18f5109ca34e34c523c979b0cb1af..83aba3ec447f5238a5601459914557204748e7e4 100644
--- a/trace_viewer/tracing/importer/v8_log_importer.html
+++ b/trace_viewer/tracing/importer/v8_log_importer.html
@@ -99,9 +99,8 @@ tvcm.exportTo('tracing.importer', function() {
this.v8_timer_thread_.sliceGroup.endSlice(end);
},
- processCodeCreateEvent_: function(type, kind, address, size, name) {
+ processCodeCreateEvent_: function(address, size, name) {
var code_entry = new tracing.importer.v8.CodeMap.CodeEntry(size, name);
- code_entry.kind = kind;
this.code_map_.addCode(address, code_entry);
},
@@ -116,25 +115,9 @@ tvcm.exportTo('tracing.importer', function() {
processSharedLibrary_: function(name, start, end) {
var code_entry = new tracing.importer.v8.CodeMap.CodeEntry(
end - start, name);
- code_entry.kind = -3; // External code kind.
- for (var i = 0; i < kV8BinarySuffixes.length; i++) {
- var suffix = kV8BinarySuffixes[i];
- if (name.indexOf(suffix, name.length - suffix.length) >= 0) {
- code_entry.kind = -1; // V8 runtime code kind.
- break;
- }
- }
this.code_map_.addLibrary(start, code_entry);
},
- findCodeKind_: function(kind) {
- for (name in CodeKinds) {
- if (CodeKinds[name].kinds.indexOf(kind) >= 0) {
- return CodeKinds[name];
- }
- }
- },
-
processTickEvent_: function(pc, start, unused_x, unused_y, vmstate, stack) {
start /= 1000;
@@ -223,7 +206,7 @@ tvcm.exportTo('tracing.importer', function() {
processor: this.processTimerEventEnd_.bind(this)
},
'code-creation': {
- parsers: [null, parseInt, parseInt, parseInt, null],
+ parsers: ['ignore', 'ignore', parseInt, parseInt, null],
processor: this.processCodeCreateEvent_.bind(this)
},
'code-move': {
« no previous file with comments | « trace_viewer/tracing/importer/v8/log_reader.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b