Skip to content

Improve development setup experience by fixing misspelled areas #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Improve development setup experience by fixing misspelled areas #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
# Issues
Before open issue, please make sure your problem/request is open or not. When open issue, please give following information if you can:
Before opening an issue, please make sure your problem/request doesn't exist. When you open issue, please provide the following information if possible:

* Example code or repo(Please keep it simple and minimal)
* Reproduce steps
* Example code or repo (please keep it simple and minimal)
* Steps to reproduce
* `react-bootstrap-table2` version

Anyway, it's welcome to open issue to ask questions or feature request.
Anyway, you're welcome to open an issue to ask questions or discuss about a feature request.

# Pull Requests
Check [here](./docs/development.md) for getting start development.
Check [here](./docs/development.md) for getting started with development.

* When you want to implement a new feature, please let us know(via issues).
* Please run test before opening PR and also remember to write test code.
* If you PR is trying to fix bug, please describe the bug when PR open.
* When you want to implement a new feature, please let us know (via issues).
* Please run tests before opening a PR and also remember to test the actual business logic.
* If your PR is trying to fix a bug, please describe the bug number with hashtag when creating the PR.

# For the member of react-bootstrap-table2 org
# For the members of react-bootstrap-table2 org

* Please convert ticket to issue when ticket move to `Ready` from `Backlog` in project
* Please write document if any new API/feature/props changed or added
* Please add story example if any new feature implement
* Please convert the ticket to issue when is ticket moved from `Backlog` to `Ready` in project.
* Please write documentation if any new API/feature/props is changed or added.
* Please add a story example if any new feature is implemented
2 changes: 1 addition & 1 deletion docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ $ npm start
```

### Launch StoryBook
We use [storybook](https://storybook.js.org/) to list our examples and it also have hot reload from source code. Sometime, it is also a good entry point to develop.
We use [storybook](https://storybook.js.org/) to list our examples and it also has hot reload from source code. Sometimes, it is also a good entry point to development.

```bash
$ cd packages/react-bootstrap-table2-example
Expand Down