Skip to content

Conversation

@osiux
Copy link
Contributor

@osiux osiux commented Dec 6, 2018

Fix #2

Trying to add a footer for the table, this is a early PR just to ask if I'm in the right track.

@osiux osiux changed the title Add table footer [WIP] Add table footer Dec 6, 2018
@jonathanborges
Copy link

Any dates? This will be great!

@AllenFang
Copy link
Member

AllenFang commented Jan 2, 2019

Sorry for lately reply, i will check this out. Thanks @osiux

@ghost
Copy link

ghost commented Jan 6, 2019

looking forward to the table summary/footer feature

@isuruamantha
Copy link

@AllenFang Could you please review the PR and merge it so that we can start using it

@ShanikaEdiriweera
Copy link

@AllenFang waiting for the feature. Much appreciated if you can review soon. Thanks 👍

@danielfelgar
Copy link

@AllenFang i'm waiting for review and merge this PR too.

@jonathanborges
Copy link

All I want is a line on the end of the table. That I can pass infos inside. Simple as that. I'm really looking forward to this feature, keep us informed, please, again, this will be awesome!

@AllenFang
Copy link
Member

guys... sorry I got serious disease from last week... will try to back in this weekend.

@osiux
Copy link
Contributor Author

osiux commented Jan 15, 2019

@AllenFang take your time to get better :) i think functionality wise this is done, just need to finish tests (that are mostly the same as for header)

@AllenFang
Copy link
Member

Thanks @osiux :)

@AllenFang AllenFang merged commit 58cfdac into react-bootstrap-table:develop Jan 20, 2019
@AllenFang
Copy link
Member

@AllenFang
Copy link
Member

thanks @osiux again 👍

@jonathanborges
Copy link

Great job, you guys don't even know how this was important for our business.

@AllenFang
Copy link
Member

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants