Skip to content

Update README.md #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2018
Merged

Update README.md #658

merged 3 commits into from
Nov 10, 2018

Conversation

@konekoya
Copy link
Contributor

@konekoya konekoya commented Nov 9, 2018

Some improvements made in README.md :)
@konekoya
Copy link
Contributor Author

konekoya commented Nov 9, 2018 •
edited
Loading

@AllenFang I've also noticed that you're using yarn in the README.md but npm in development.md. I think it would be better if we use the same package manager across all the docs to avoid confusion.
YassienW
YassienW suggested changes Nov 9, 2018
View reviewed changes
YassienW and others added 2 commits November 10, 2018 05:21
@YassienW @konekoya
Address review comment
3829ded 
Co-Authored-By: konekoya <tank158r5155@yahoo.com.tw>
@YassienW @konekoya
Use being instead of is
6290528 
Co-Authored-By: konekoya <tank158r5155@yahoo.com.tw>
@AllenFang AllenFang changed the base branch from master to develop November 10, 2018 06:42
@AllenFang
Copy link
Member

AllenFang commented Nov 10, 2018

thanks @konekoya and @YassienW
@AllenFang AllenFang merged commit 28f3c33 into react-bootstrap-table:develop Nov 10, 2018
YassienW pushed a commit to YassienW/react-bootstrap-table2 that referenced this pull request Nov 14, 2018
@konekoya
Update README.md (react-bootstrap-table#658)
37f6a80 
* Update README.md * Address review comment Co-Authored-By: konekoya <tank158r5155@yahoo.com.tw> * Use being instead of is Co-Authored-By: konekoya <tank158r5155@yahoo.com.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@konekoya @AllenFang @YassienW