Skip to content

Conversation

@Ignalion
Copy link
Contributor

#199

Hi, @AllenFang

This is my draft implementation of multi select. I think it works pretty stratiforward although It might cause some issues while using with remote bc I didn't test it.

Please take a look if it's ok with your thoughts.

P.S. I rebased my branch to develop so had to recreate PR

@Ignalion
Copy link
Contributor Author

Hi, @AllenFang

Actually I have a couple more ideas about custom filters so could you please review the PR to say whether it's OK from your perspective? I'd like to implement range filter as well, I think the same way.

@AllenFang
Copy link
Member

@Ignalion sure, sorry I'm a little busy recently, will have a look in this couple day, thanks

@AmitKKhanchandani
Copy link

@AllenFang is it possible to merge this today?

Currently, my project needs a multifilter select functionality, any help/idea how would I add achieve this?

{
"name": "react-bootstrap-table2-example",
"version": "0.1.10",
"version": "0.1.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don''t patch version manually, we use lerna. Please remove this changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just rebased branch to develop, i.e. i didn't patch it manually. it came from develop branch, I think

@AllenFang
Copy link
Member

@AmitKKhanchandani sorry, I think I still need some works on this PR, if ok, probably able to release in this weekend.

@AllenFang
Copy link
Member

AllenFang commented Jul 28, 2018

@Ignalion I think you have to rebase your branch firstly. This PR contain a wrong commit in this patch. If you feel hard to rebase, you can

  1. recreate a new branch
  2. cherry pick your patch from current branch to new branch
  3. submit a new PR.
@Ignalion Ignalion mentioned this pull request Jul 29, 2018
@Ignalion
Copy link
Contributor Author

I rebased branch from develop and re-created PR #438

@Ignalion Ignalion closed this Jul 29, 2018
@AllenFang
Copy link
Member

released on react-bootstrap-table2-filter@0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants