Prevent remote pagination from setting the page incorrectly #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @sean-ww thanks, i will check this out :) |
Closed
AllenFang approved these changes Jun 21, 2018
Member
| @sean-ww thanks your contribution, this patch released on |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The issue:
When changing pages on a remote implementation with filters componentWillReceiveProps fires twice. It fires once on the initial page change click, and again when the updated data is received. Therefore, when data (2nd time it fires) is received the current logic believes a page hasn't been selected. It subsequently sets the current page to the start index value incorrectly.
For example, with my remote implementation: if I select page 4, the second time pagination componentWillReceiveProps fires, I end up with page 1 being selected whilst I have received page 4 data.