Skip to content

Refarcotring Wrapper #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2017
Merged

Refarcotring Wrapper #158

merged 3 commits into from
Dec 25, 2017

Conversation

@AllenFang
Copy link
Member

@AllenFang AllenFang commented Dec 25, 2017

  1. Decide which Base Component when contaner initialization to avoid the componentWillReceieve not being called when props update

  2. Follow up the first point, use HoC again instead of React.createElement

  3. Follow up the second point, it will be easy to inject some useful modules to other wrappers which is not inside the react-bootstrap-table2 package

  4. Handle remote centrally (But I think we can do more better in the future)
@AllenFang AllenFang added this to the 0.1.0 milestone Dec 25, 2017
@AllenFang AllenFang requested a review from chunming-c December 25, 2017 09:40
@AllenFang
Copy link
Member Author

AllenFang commented Dec 25, 2017

@Chun-MingChen
@AllenFang AllenFang merged commit bdfc4eb into develop Dec 25, 2017
@AllenFang AllenFang deleted the enhance/refactoring branch December 25, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement technical

2 participants

@AllenFang