More precise hrtime() return type #4353
Open
+13 −8
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
hrtime(true)always returns positive-int.hrtime(false)returns an array of[second, nanosecond], where second is positive-int and nanosecond is between 0 and 10⁹-1 (because 10⁹ nanosecond = 1 second)Another solution
I tried to remove the return type extension and add a stub like this:
but this doesn't work:
falseseems to come from phpstan/php-8-stubs.https://github.com/phpstan/php-8-stubs/blob/0.4.30/stubs/ext/standard/hrtime.php
I also tried this stub:
This works in most cases, but we see
falsewhen argument is not bool: