Refinement of DatepickerType with Conditional Types based on asSingle Property #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Refined the DatepickerType interface to use conditional types. Now, the value type is determined by the asSingle property. When asSingle is true, value is of type DateType, otherwise, it's DateValueType.
Abdel-Monaam-Aouini approved these changes Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces a refinement to the
DatepickerTypeinterface to leverage TypeScript's conditional types. The aim is to provide clearer typing based on theasSingleproperty value.Details:
DatepickerTypeinterface.asSingleis set totrue, thevaluetype becomesDateType.asSingleis set tofalseor is undefined, thevaluetype defaults toDateValueType.