- Notifications
You must be signed in to change notification settings - Fork 426
fix: fixes an issue with npm 6 #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Benchmark resultsComparing with 001b584 Package size: 357 MB⬆️ 0.50% increase vs. 001b584
Legend
|
This is unfortunately still failing:
It seems like using |
really weird as I cannot reproduce it on my machine with npm@6. Wich version are you using exactly? |
I am using |
Good Point! I'm on MacOS and used `v12.22.7 (npm 6.14.15) |
@ehmicky now I start thinking that your machine has maybe an issue: Just setted up a VM with ubuntu install node.js and npm 6 and it works: |
I think I have found a few sites which seem to reproduce this problem. I have added the links on the main issue. |
Looks like |
@erezrokah the odd thing is that I cannot reproduce it at all (trying my best currently with all types of node install on vms and on my mac) |
Could we remove |
f1e5f4a
to 03b18a4
Compare
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #3869
I tried running
netlify-cli@8.2.0-rc.0
and it worked. Sadly I could not reproduce it by runningnpm install netlify-cli
on the latest version.I did so on:
maybe @ehmicky you can verify if the rc version works for you?
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)