Skip to content

Conversation

lukasholzer
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #3869

I tried running netlify-cli@8.2.0-rc.0 and it worked. Sadly I could not reproduce it by running npm install netlify-cli on the latest version.

I did so on:

 ────────────────────┐ Environment Info │ ────────────────────┘ System: OS: macOS 12.1 CPU: (10) x64 Apple M1 Max Binaries: Node: 12.22.7 - ~/.nvm/versions/node/v12.22.7/bin/node npm: 6.14.15 - ~/.nvm/versions/node/v12.22.7/bin/npm Browsers: Chrome: 96.0.4664.110 Safari: 15.2 

maybe @ehmicky you can verify if the rc version works for you?

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested a review from ehmicky December 20, 2021 16:10
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 20, 2021
@github-actions
Copy link

github-actions bot commented Dec 20, 2021

📊 Benchmark results

Comparing with 001b584

Package size: 357 MB

⬆️ 0.50% increase vs. 001b584

^ 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 358 MB 357 MB │ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| └───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──> T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T 
Legend
@ehmicky
Copy link
Contributor

ehmicky commented Dec 20, 2021

This is unfortunately still failing:

$ nvm use 12 Now using node v12.20.0 (npm v6.14.8) $ npm i netlify-cli@8.2.0-rc.0 npm WARN checkPermissions Missing write access to /home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules npm ERR! code ENOENT npm ERR! syscall access npm ERR! path /home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules npm ERR! errno -2 npm ERR! enoent ENOENT: no such file or directory, access '/home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules' npm ERR! enoent This is related to npm not being able to find a file. npm ERR! enoent 

It seems like using file: as a version in dependencies might be incompatible with npm@6 🤔

@lukasholzer
Copy link
Contributor Author

This is unfortunately still failing:

$ nvm use 12 Now using node v12.20.0 (npm v6.14.8) $ npm i netlify-cli@8.2.0-rc.0 npm WARN checkPermissions Missing write access to /home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules npm ERR! code ENOENT npm ERR! syscall access npm ERR! path /home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules npm ERR! errno -2 npm ERR! enoent ENOENT: no such file or directory, access '/home/user/repo/node_modules/netlify-cli/node_modules/eslint-plugin-local-rules' npm ERR! enoent This is related to npm not being able to find a file. npm ERR! enoent 

It seems like using file: as a version in dependencies might be incompatible with npm@6 🤔

really weird as I cannot reproduce it on my machine with npm@6. Wich version are you using exactly?

@ehmicky
Copy link
Contributor

ehmicky commented Dec 20, 2021

I am using v12.20.0 (npm v6.14.8).
Maybe this is OS-specific? I am on Linux (Ubuntu).

@lukasholzer
Copy link
Contributor Author

I am using v12.20.0 (npm v6.14.8). Maybe this is OS-specific? I am on Linux (Ubuntu).

Good Point! I'm on MacOS and used `v12.22.7 (npm 6.14.15)

@lukasholzer
Copy link
Contributor Author

@ehmicky now I start thinking that your machine has maybe an issue:

Just setted up a VM with ubuntu install node.js and npm 6 and it works:

CleanShot 2021-12-20 at 18 21 29@2x

@ehmicky
Copy link
Contributor

ehmicky commented Dec 20, 2021

I think I have found a few sites which seem to reproduce this problem. I have added the links on the main issue.

@erezrokah
Copy link
Contributor

Looks like npm recommends using a node version manager to workaround this (which is odd on its own).

@lukasholzer
Copy link
Contributor Author

@erezrokah the odd thing is that I cannot reproduce it at all (trying my best currently with all types of node install on vms and on my mac)

@erezrokah
Copy link
Contributor

Could we remove eslint-plugin-local-rules for now to fix this, and then publish it as a separate package?

@lukasholzer lukasholzer force-pushed the fix/fix-npm-6-install-error branch from f1e5f4a to 03b18a4 Compare December 21, 2021 11:14
@lukasholzer lukasholzer added the automerge Add to Kodiak auto merge queue label Dec 21, 2021
@kodiakhq kodiakhq bot merged commit f30418a into main Dec 21, 2021
@kodiakhq kodiakhq bot deleted the fix/fix-npm-6-install-error branch December 21, 2021 15:11
@erezrokah erezrokah mentioned this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code

3 participants