Added another method to 2sum Problem #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
ignacio-chiazzo left a comment
ignacio-chiazzo left a comment There was a problem hiding this comment.
Hey! Thanks for contributing
Comment on lines +44 to 51
| for (let i = 0; i < nums.length; i++) { | ||
| for (let j = i + 1; j < nums.length; i++) { | ||
| if (nums[1] + nums[j] === target) { | ||
| return [i, j]; | ||
| } | ||
| } | ||
| } | ||
| }; |
Owner
There was a problem hiding this comment.
Could you encapsulate the new solution into a new method named twoSum2?
There are other examples in other files like CoinChange https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/blob/08563058f7e93ce1688956cc26d5dc2a98b36d1a/LeetcodeProblems/Algorithms/Coin_Change.js.
Also, could you run the tests for both functions twoSum and twoSum2?
Contributor Author
There was a problem hiding this comment.
Alright.. i would fix that
Contributor Author
| I have updated it.. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added another method that can be used to solve 2sum.
kindly review, Thank you