This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Rename type MaybePromise to PromiseOrValue as in graphql-js #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kyarik force-pushed the rename-maybepromise-to-promiseorvalue branch 2 times, most recently from c0abe98 to 09050f6 Compare 
kyarik force-pushed the rename-maybepromise-to-promiseorvalue branch 2 times, most recently from 01fb10d to 6ac8c09 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
MaybePromise<T>can be misinterpreted asMaybe<Promise<T>>. Naming this type asPromiseOrValue<T>makes it clear what this type represents and prevents the aforementioned possible misinterpretation.PromiseOrValue<T>is also defined ingraphql-js(graphql-js/PromiseOrValue.d.ts), so it makes sense to keep the type name consistent.