[2022.04.26] level2 - 예상대진표 풀이 추가 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| 제 PR 인줄 알고 close 누르고 reopen 했습니다..!! |
codeisneverodd approved these changes Apr 27, 2022
Owner
codeisneverodd left a comment
codeisneverodd left a comment There was a problem hiding this comment.
좋은 코드 잘 보았습니다 😁
함수를 적절히 분리해주신 점이 너무 좋았습니다!!
꼭 개선해주셨으면 하는 부분은 없어 확인후 Merge 진행합니다!
level-2/예상-대진표.js Outdated
Comment on lines +34 to +38
Owner
There was a problem hiding this comment.
🌱 반영해도 좋고 넘어가도 좋아요. 🌱
위의 다른 코드들 처럼 ternary operator를 사용해보시는 것도 좋을 것 같습니다!
Suggested change
| if (isLeft()) { | |
| arr.splice(arr.length / 2) | |
| } else { | |
| arr.splice(0, arr.length / 2) | |
| } | |
| isLeft() ? arr.splice(arr.length / 2) : arr.splice(0, arr.length / 2) |
level-2/예상-대진표.js Outdated
Comment on lines +24 to +26
Owner
There was a problem hiding this comment.
🌱 반영해도 좋고 넘어가도 좋아요. 🌱
불필요한 tenary operator가 사용되어 가독성이 조금 떨어진다고 생각합니다! boolean 값을 직접 리턴 하시는 것보단 비교문 그 자체를 쓰시는 것이 좋을 것이라 생각됩니다!
Suggested change
| return ( | |
| (arr.indexOf("A") + 1 > arr.length / 2 && arr.indexOf("B") + 1 <= arr.length / 2) || | |
| (arr.indexOf("A") + 1 <= arr.length / 2 && arr.indexOf("B") + 1 > arr.length / 2)) ? true : false | |
| return ( | |
| (arr.indexOf("A") + 1 > arr.length / 2 && arr.indexOf("B") + 1 <= arr.length / 2) || | |
| (arr.indexOf("A") + 1 <= arr.length / 2 && arr.indexOf("B") + 1 > arr.length / 2)) |
level-2/예상-대진표.js Outdated
Owner
There was a problem hiding this comment.
🌱 반영해도 좋고 넘어가도 좋아요. 🌱
이전 코멘트와 동일하게 불필요한 boolean 값들을 제거하시면 더 좋을 것이라 생각합니다!
Suggested change
| return (arr.indexOf("A") + 1 > arr.length / 2) ? false : true | |
| return arr.indexOf("A") + 1 <= arr.length / 2 |
Contributor Author
There was a problem hiding this comment.
이 생각은 전혀 못했었네요 항상 좋은 리뷰 감사드립니다! ㅎㅎ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
대진표가 부전승이 없는 특성을 이용해서 풀이했습니다. 리뷰 부탁드립니다