[정기적 문제 풀이 추가 PR] 2022.04.19 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
codeisneverodd approved these changes Apr 20, 2022
Owner
codeisneverodd left a comment
codeisneverodd left a comment There was a problem hiding this comment.
많은 문제를 풀이하셨군요!! 좋은 코드 잘 보았습니다 😄
주석도 잘 남겨주셔서 읽기 용이했습니다.
주석 중에 '정답' 표시가 들어가있지 않은 것이 있어서, 사소하기에 제가 바로 수정했습니다!
리뷰 내용 확인하고 Merge 부탁드립니다 👍
level-1/나누어-떨어지는-숫자-배열.js Outdated
Comment on lines +33 to +34
Owner
There was a problem hiding this comment.
answer = arr.filter(v=> v%divisor === 0) 과 같이 나타낼 수 있을 것도 좋을 것 같습니다 😄
Contributor Author
There was a problem hiding this comment.
코드가 휠씬 간격해지네요 👍
level-1/문자열-내-마음대로-정렬하기.js Outdated
Comment on lines +29 to +34
Owner
There was a problem hiding this comment.
charCodeAt 메서드를 활용하신다면 a.charCodeAt(n)과 같은 형태가 더 적절하지 않을까 생각합니다!
참고문서
https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/charCodeAt
Contributor Author
There was a problem hiding this comment.
공식문서를 따르겠습니다! 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
[level1]
최소직사각형.js
�정수-내림차순으로-배치하기.js
이상한-문자-만들기.js
예산.js
악수의-합.js
시저-암호.js
수박수박수박수박수박.js
서울에서-김서방-찾기.js
부족한-금액-계산하기.js
문자열-내림차순으로-배치하기.js
문자열-내-마음대로-정렬하기.js
두-정수-사이의-합.js
두-개-뽑아서-더하기.js
나머지가-1이-되는-수-찾기.js
나누어-떨어지는-숫자-배열.js
같은-숫자는-싫어.js
3진법-뒤집기.js