Skip to content

Dockerfile improvements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2020
Merged

Dockerfile improvements #6

merged 2 commits into from
Jan 20, 2020

Conversation

@petrudumuta
Copy link

@petrudumuta petrudumuta commented Jan 20, 2020

Changes

  • switch to a minimal Python 3.7 base image
  • changed from copying the FRED code from the working copy instead of fetching it from github

With the changes above, the generated docker image size is now ~ 4 GB (from 8 GB previously)
@petrudumuta petrudumuta reopened this Jan 20, 2020
dumitrescustefan
dumitrescustefan approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@dumitrescustefan dumitrescustefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right
@dumitrescustefan dumitrescustefan merged commit cabbb19 into adobe:master Jan 20, 2020
@petrudumuta petrudumuta deleted the dockerfile branch January 20, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@petrudumuta @dumitrescustefan