Merge Challenges from joes-branch #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
boinary requested changes Nov 1, 2019
Contributor
boinary left a comment
boinary left a comment There was a problem hiding this comment.
just fix these changes please
Added comments to Kids Shapes Toy-Joe.py Changed -0 to 0 in Transaction-Joe.py as well as changed the loop overrun to something more apropriate.
Removed the `and` from mood choice in Happy-Face Added comments to circle in a square
boinary approved these changes Nov 1, 2019
Contributor
boinary left a comment
boinary left a comment There was a problem hiding this comment.
Changes look good - make sure to update in CodeHS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Includes 2.19.6, 2.9.7, 4.3.10 and 4.4.6