Skip to content

Conversation

@tbodt
Copy link
Contributor

@tbodt tbodt commented Sep 7, 2025

Pull Request

Related Issues

Closes #

Summary of Changes

Testing

  • Ran all existing tests
  • Added new tests
  • Manually tested features

Checklist

  • My code follows the project’s coding style.
  • I have added tests that prove my fix/feature works.
  • I have updated documentation where necessary.
  • My changes do not break existing functionality.
  • I have rebased on the latest main branch.

Additional Notes

@zinja-coder
Copy link
Owner

Hi, First of all thank you for this. However, I can not merge this request as creating jadx_mcp_server might result in issues. Here are my reasons:

    1. Using uv run approach ensure zero dependencies issues.
    1. This might conflict with other existing python packages.
    1. There is no drawback of using this as a python script file as no issues have been reported.

My main concern is users will then switch to using executable jadx_mcp_server.py which might conflict with other python packages in their system. So far we have zero dependency related issue reported due to use of uv run approach. However, I might be wrong. Please correct my points if you think there is any benefit of using executable instead of uv run.

@tbodt
Copy link
Contributor Author

tbodt commented Sep 9, 2025

This is for use with uv tool install which installs the thing in its own virtualenv and then are no dependency issues conflicts or drawbacks. It makes installation that much easier

uv tool install git+https://github.com/zinja-coder/jadx-mcp-server 

and then jadx_mcp_server is available on your path, can specify the path directly in claude json config, no arguments needed.

@zinja-coder zinja-coder merged commit 70970e4 into zinja-coder:main Sep 10, 2025
@zinja-coder
Copy link
Owner

Thank you so much for the response and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants