Add tests for handling non-strings in 'override_tag's 'default_html' parameter

Author: alxbridge

tests/templates/patterns/atoms/tags_test_atom/invalid_tags_test_atom.html

@@ -0,0 +1,5 @@
+{% load test_tags_invalid %}
+
+MARMA{% default_html_tag_invalid empty_string %}LADE01
+MARMA{% default_html_tag_invalid none %}LADE02
+MARMA{% default_html_tag_invalid dict %}LADE03

tests/templates/patterns/atoms/tags_test_atom/invalid_tags_test_atom.yaml

@@ -0,0 +1,12 @@
+context:
+ test_invalid_tags: False
+tags:
+ default_html_tag_invalid:
+ empty_string:
+ raw: ''
+ none:
+ raw: None
+ dict:
+ zero: 0
+ two: 2
+ five: 5

tests/templatetags/test_tags_invalid.py

@@ -0,0 +1,15 @@
+from django import template
+
+from pattern_library.monkey_utils import override_tag
+
+register = template.Library()
+
+
+@register.simple_tag()
+def default_html_tag_invalid(arg=None):
+ "Just pass, never do anything"
+ pass
+
+
+# Test overriding tag with a default_html that's not valid in Django >= 4.0
+override_tag(register, "default_html_tag_invalid", default_html=[1, 2, 3])

tests/tests/test_commands.py

@@ -16,6 +16,7 @@ def test_displays_patterns(self):
  call_command("render_patterns", dry_run=True, stdout=stdout, stderr=stderr)
  self.assertIn(
  """patterns/atoms/tags_test_atom/tags_test_atom.html
+patterns/atoms/tags_test_atom/invalid_tags_test_atom.html
 patterns/atoms/test_atom/test_atom.html
 """,
  stderr.getvalue(),

tests/tests/test_tags.py

@@ -1,4 +1,5 @@
 from django.test import SimpleTestCase
+from unittest.mock import patch
 
 from .utils import reverse
 
@@ -43,3 +44,32 @@ def test_falsey_default_html_overide(self):
  self.assertContains(response, "POTATO1")
  self.assertContains(response, "POTANoneTO2")
  self.assertContains(response, "POTA0TO3")
+
+ def test_bad_default_html_warning(self):
+ with patch("django.VERSION", (3, 2, 0, "final", 0)):
+ with self.assertWarns(Warning) as cm:
+ response = self.client.get(
+ reverse(
+ "pattern_library:render_pattern",
+ kwargs={
+ "pattern_template_name": "patterns/atoms/tags_test_atom/invalid_tags_test_atom.html",
+ },
+ ),
+ )
+ self.assertContains(response, "MARMALADE01")
+ self.assertContains(response, "MARMANoneLADE02")
+ self.assertIn(
+ "default_html argument to override_tag should be a string to ensure compatibility with Django",
+ str(cm.warnings[0]),
+ )
+
+ def test_bad_default_html_error(self):
+ with patch("django.VERSION", (4, 2, 0, "final", 0)):
+ with self.assertRaises(TypeError) as cm:
+ self.client.get(
+ reverse(
+ "pattern_library:render_pattern",
+ kwargs={"pattern_template_name": "patterns/atoms/tags_test_atom/invalid_tags_test_atom.html"},
+ ),
+ )
+ self.assertIn("default_html argument to override_tag must be a string", str(cm.exception))