Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit 83a3f01

Browse files
committed
Refactor
1 parent 5f06a45 commit 83a3f01

File tree

15 files changed

+141
-211
lines changed

15 files changed

+141
-211
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
node_modules/
2-
2+
dist/
33
*.vsix
44

55
/.vs
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
node_modules
2+
dist

BuildTasks/WinAppDriverInstaller/.taskkey

Lines changed: 0 additions & 1 deletion
This file was deleted.

BuildTasks/WinAppDriverInstaller/installer.js

Lines changed: 0 additions & 107 deletions
This file was deleted.

BuildTasks/WinAppDriverInstaller/installer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import * as taskLib from 'azure-pipelines-task-lib/task';
22
import * as toolLib from 'azure-pipelines-tool-lib/tool';
33

44
import * as util from 'util';
5-
const exec = util.promisify(require('child_process').exec);
5+
const exec = util.promisify(require('node-windows').elevate);
66

77
async function execCommand(command: string) {
88
console.log('command: ' + command);
9-
const { stdout, stderr } = await exec(command);
9+
const { stdout, stderr }: { stdout: string|null, stderr: string|null } = await exec(command);
1010
if (stdout) {
1111
console.log('stdout: ' + stdout);
1212
}

BuildTasks/WinAppDriverInstaller/package-lock.json

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

BuildTasks/WinAppDriverInstaller/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "winappdriverinstaller",
33
"version": "0.0.1",
44
"description": "Install WinAppDriver",
5-
"main": "installer.js",
5+
"main": "dist/installer.js",
66
"scripts": {
77
"test": "echo \"Error: no test specified\" && exit 1",
88
"tsc": "tsc"
@@ -15,7 +15,8 @@
1515
"license": "ISC",
1616
"dependencies": {
1717
"azure-pipelines-task-lib": "^2.9.3",
18-
"azure-pipelines-tool-lib": "^0.12.0"
18+
"azure-pipelines-tool-lib": "^0.12.0",
19+
"node-windows": "^0.1.14"
1920
},
2021
"devDependencies": {
2122
"@types/node": "^12.7.9",

BuildTasks/WinAppDriverInstaller/task.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"id": "8cc922ae-6951-48d4-861e-d306b6c6fbc3",
44
"name": "WinAppDriverInstaller",
55
"friendlyName": "WinAppDriver Installer",
6-
"description": "Install WinAppDriver",
6+
"description": "Install WinAppDriver to agent",
77
"helpMarkDown": "https://github.com/react-native-windows/WinAppDriverInstaller",
88
"category": "Utility",
99
"visibility": [
@@ -28,7 +28,7 @@
2828
],
2929
"execution": {
3030
"Node10": {
31-
"target": "installer.js"
31+
"target": "dist/installer.js"
3232
}
3333
}
3434
}
Lines changed: 11 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,63 +1,14 @@
11
{
22
"compilerOptions": {
3-
/* Basic Options */
4-
// "incremental": true, /* Enable incremental compilation */
5-
"target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
6-
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
7-
"lib": ["es2015"], /* Specify library files to be included in the compilation. */
8-
// "allowJs": true, /* Allow javascript files to be compiled. */
9-
// "checkJs": true, /* Report errors in .js files. */
10-
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
11-
// "declaration": true, /* Generates corresponding '.d.ts' file. */
12-
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
13-
// "sourceMap": true, /* Generates corresponding '.map' file. */
14-
// "outFile": "./", /* Concatenate and emit output to single file. */
15-
// "outDir": "./", /* Redirect output structure to the directory. */
16-
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
17-
// "composite": true, /* Enable project compilation */
18-
// "tsBuildInfoFile": "./", /* Specify file to store incremental compilation information */
19-
// "removeComments": true, /* Do not emit comments to output. */
20-
// "noEmit": true, /* Do not emit outputs. */
21-
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
22-
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
23-
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
24-
25-
/* Strict Type-Checking Options */
26-
"strict": true, /* Enable all strict type-checking options. */
27-
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
28-
// "strictNullChecks": true, /* Enable strict null checks. */
29-
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
30-
// "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
31-
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
32-
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
33-
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
34-
35-
/* Additional Checks */
36-
// "noUnusedLocals": true, /* Report errors on unused locals. */
37-
// "noUnusedParameters": true, /* Report errors on unused parameters. */
38-
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
39-
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
40-
41-
/* Module Resolution Options */
42-
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
43-
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
44-
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
45-
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
46-
// "typeRoots": [], /* List of folders to include type definitions from. */
47-
// "types": [], /* Type declaration files to be included in compilation. */
48-
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
49-
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
50-
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
51-
// "allowUmdGlobalAccess": true, /* Allow accessing UMD globals from modules. */
52-
53-
/* Source Map Options */
54-
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
55-
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
56-
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
57-
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
58-
59-
/* Experimental Options */
60-
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
61-
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
62-
}
3+
"module": "commonjs",
4+
"target": "es6",
5+
"sourceMap": true,
6+
"strict": false,
7+
"strictNullChecks": false,
8+
"removeComments": true,
9+
"outDir": "./dist"
10+
},
11+
"files": [
12+
"./installer.ts"
13+
]
6314
}

Installerparameter.png

8.66 KB
Loading

0 commit comments

Comments
 (0)