[#24] GET /articles/:slug/comments

Author: raeperd

src/main/java/io/github/raeperd/realworld/application/article/comment/CommentRestController.java

@@ -3,10 +3,7 @@
 import io.github.raeperd.realworld.domain.article.comment.CommentService;
 import io.github.raeperd.realworld.infrastructure.jwt.UserJWTPayload;
 import org.springframework.security.core.annotation.AuthenticationPrincipal;
-import org.springframework.web.bind.annotation.PathVariable;
-import org.springframework.web.bind.annotation.PostMapping;
-import org.springframework.web.bind.annotation.RequestBody;
-import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.bind.annotation.*;
 
 import javax.validation.Valid;
 
@@ -25,4 +22,11 @@ public CommentModel postComments(@AuthenticationPrincipal UserJWTPayload jwtPayl
  final var commentAdded = commentService.createComment(jwtPayload.getUserId(), slug, dto.getBody());
  return CommentModel.fromComment(commentAdded);
  }
+
+ @GetMapping("/articles/{slug}/comments")
+ public MultipleCommentModel getComments(@AuthenticationPrincipal UserJWTPayload jwtPayload,
+ @PathVariable String slug) {
+ final var comments = commentService.getComments(jwtPayload.getUserId(), slug);
+ return MultipleCommentModel.fromComments(comments);
+ }
 }

src/main/java/io/github/raeperd/realworld/application/article/comment/MultipleCommentModel.java

@@ -0,0 +1,22 @@
+package io.github.raeperd.realworld.application.article.comment;
+
+import io.github.raeperd.realworld.application.article.comment.CommentModel.CommentModelNested;
+import io.github.raeperd.realworld.domain.article.comment.Comment;
+import lombok.Value;
+
+import java.util.List;
+import java.util.Set;
+
+import static java.util.stream.Collectors.toList;
+
+@Value
+class MultipleCommentModel {
+
+ List<CommentModelNested> comments;
+
+ static MultipleCommentModel fromComments(Set<Comment> comments) {
+ final var commentsCollected = comments.stream().map(CommentModelNested::fromComment)
+ .collect(toList());
+ return new MultipleCommentModel(commentsCollected);
+ }
+}

src/main/java/io/github/raeperd/realworld/domain/article/Article.java

@@ -81,6 +81,11 @@ public void updateArticle(ArticleUpdateRequest updateRequest) {
  contents.updateArticleContentsIfPresent(updateRequest);
  }
 
+ public Article updateFavoriteByUser(User user) {
+ favorited = userFavorited.contains(user);
+ return this;
+ }
+
  public User getAuthor() {
  return author;
  }
@@ -105,9 +110,8 @@ public boolean isFavorited() {
  return favorited;
  }
 
- public Article updateFavoriteByUser(User user) {
- favorited = userFavorited.contains(user);
- return this;
+ public Set<Comment> getComments() {
+ return comments;
  }
 
  @Override

src/main/java/io/github/raeperd/realworld/domain/article/comment/CommentService.java

@@ -1,11 +1,13 @@
 package io.github.raeperd.realworld.domain.article.comment;
 
 import io.github.raeperd.realworld.domain.article.ArticleFindService;
+import io.github.raeperd.realworld.domain.user.User;
 import io.github.raeperd.realworld.domain.user.UserFindService;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.NoSuchElementException;
+import java.util.Set;
 
 import static org.springframework.data.util.Optionals.mapIfAllPresent;
 
@@ -26,4 +28,11 @@ public Comment createComment(long userId, String slug, String body) {
  (user, article) -> user.writeCommentToArticle(article, body))
  .orElseThrow(NoSuchElementException::new);
  }
+
+ @Transactional(readOnly = true)
+ public Set<Comment> getComments(long userId, String slug) {
+ return mapIfAllPresent(userFindService.findById(userId), articleFindService.getArticleBySlug(slug),
+ User::viewArticleComments)
+ .orElseThrow(NoSuchElementException::new);
+ }
 }

src/main/java/io/github/raeperd/realworld/domain/user/User.java

@@ -11,6 +11,7 @@
 import java.util.Objects;
 import java.util.Set;
 
+import static java.util.stream.Collectors.toSet;
 import static javax.persistence.CascadeType.REMOVE;
 import static javax.persistence.GenerationType.IDENTITY;
 
@@ -89,6 +90,17 @@ User unfollowUser(User followee) {
  return this;
  }
 
+ public Set<Comment> viewArticleComments(Article article) {
+ return article.getComments().stream()
+ .map(this::viewComment)
+ .collect(toSet());
+ }
+
+ Comment viewComment(Comment comment) {
+ viewProfile(comment.getAuthor());
+ return comment;
+ }
+
  Profile viewProfile(User user) {
  return user.profile.withFollowing(followingUsers.contains(user));
  }

src/test/java/io/github/raeperd/realworld/IntegrationTest.java

@@ -217,7 +217,18 @@ void create_comments_for_article() throws Exception {
  .header(AUTHORIZATION, "Token " + token)
  .contentType(APPLICATION_JSON)
  .content("{\"comment\":{\"body\":\"Thank you so much!\"}}"))
- .andExpect(status().isOk());
+ .andExpect(status().isOk())
+ .andExpect(validSingleCommentModel())
+ .andExpect(jsonPath("comment.body", is("Thank you so much!")));
+ }
+
+ @Order(12)
+ @Test
+ void all_comments_for_article() throws Exception {
+ mockMvc.perform(get("/articles/{slug}/comments", "how-to-train-your-dragon")
+ .header(AUTHORIZATION, "Token " + token))
+ .andExpect(status().isOk())
+ .andExpect(validMultipleCommentModel());
  }
 
  @Order(12)

src/test/java/io/github/raeperd/realworld/IntegrationTestUtils.java

@@ -73,4 +73,25 @@ private static ResultMatcher validArticleModelInPath(String path) {
  jsonPath(path + ".favoritesCount").isNumber(),
  validProfileModelInPath(path + ".author"));
  }
+
+ static ResultMatcher validSingleCommentModel() {
+ return matchAll(
+ jsonPath("comment").isMap(),
+ validCommentModelInPath("comment"));
+ }
+
+ static ResultMatcher validMultipleCommentModel() {
+ return matchAll(
+ jsonPath("comments").isArray(),
+ validCommentModelInPath("comments[0]"));
+ }
+
+ private static ResultMatcher validCommentModelInPath(String path) {
+ return matchAll(
+ jsonPath(path + ".id").isNumber(),
+ jsonPath(path + ".body").isString(),
+ jsonPath(path + ".createdAt", matchesPattern(ISO_8601_PATTERN)),
+ jsonPath(path + ".updatedAt", matchesPattern(ISO_8601_PATTERN)),
+ validProfileModelInPath(path + ".author"));
+ }
 }