Skip to content

Commit 48d6aad

Browse files
committed
Update PyOpenSci links to guidebook
- Update PyOpenSci links to guidebook - Configure links as references
1 parent 6f2840f commit 48d6aad

File tree

4 files changed

+72
-21
lines changed

4 files changed

+72
-21
lines changed

.github/ISSUE_TEMPLATE/help-request.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ assignees: ''
99

1010
## What is this?
1111

12-
To make the review process easier and to help you maintain your package, pyOpenSci requires testing, continuous integration, and full documentation for packages submitted for review (read more [here](https://www.pyopensci.org/dev_guide/packaging/packaging_guide.html#overview). We want to make this as easy as possible for newcomers, so if you'd like some help in prepping your package you can submit this request and we'll assign someone to help you out!
12+
To make the review process easier and to help you maintain your package, pyOpenSci requires testing, continuous integration, and full documentation for packages submitted for review (read more [here][PackagingGuide]. We want to make this as easy as possible for newcomers, so if you'd like some help in prepping your package you can submit this request and we'll assign someone to help you out!
1313

14-
Before submitting a request, check out our [Packaging Guide](https://www.pyopensci.org/dev_guide/packaging/packaging_guide.html). The answers to your questions might be there already.
14+
Before submitting a request, check out our [Packaging Guide][PackagingGuide]. The answers to your questions might be there already.
1515

1616

1717
## Package Info
@@ -26,7 +26,7 @@ Repository Link (if existing):
2626
2727
```
2828

29-
- Please indicate which [category or categories](https://pyopensci.github.io/dev_guide/peer_review/peer_review_proc.html#aims-and-scope) this package falls under:
29+
- Please indicate which [category or categories][PackageCatagories] this package falls under:
3030
- [ ] Data retrieval
3131
- [ ] Data extraction
3232
- [ ] Data munging
@@ -54,5 +54,11 @@ Repository Link (if existing):
5454
- Any other questions or issues we should be aware of?:
5555

5656

57+
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments]
5758

58-
**P.S.** *Have feedback/comments about our review process? Leave a comment [here](https://github.com/pyOpenSci/governance/issues/8)*
59+
60+
[PackagingGuide]: https://www.pyopensci.org/contributing-guide/authoring/index.html#packaging-guide
61+
62+
[PackageCatagories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories
63+
64+
[Comments]: https://github.com/pyOpenSci/governance/issues/8

.github/ISSUE_TEMPLATE/presubmission-inquiry.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Repository Link (if existing):
2020

2121
## Scope
2222

23-
- Please indicate which [category or categories](https://pyopensci.github.io/dev_guide/peer_review/peer_review_proc.html#aims-and-scope) this package falls under:
23+
- Please indicate which [category or categories][PackageCatagories] this package falls under:
2424
- [ ] Data retrieval
2525
- [ ] Data extraction
2626
- [ ] Data munging
@@ -41,4 +41,9 @@ Repository Link (if existing):
4141

4242

4343

44-
**P.S.** *Have feedback/comments about our review process? Leave a comment [here](https://github.com/pyOpenSci/governance/issues/8)*
44+
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments]
45+
46+
47+
[PackageCatagories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories
48+
49+
[Comments]: https://github.com/pyOpenSci/governance/issues/8

.github/ISSUE_TEMPLATE/submit-software-for-review.md

Lines changed: 34 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Version accepted: TBD
2525
- Include a brief paragraph describing what your package does:
2626

2727
## Scope
28-
- Please indicate which [category or categories](https://www.pyopensci.org/dev_guide/peer_review/aims_scope.html) this package falls under:
28+
- Please indicate which [category or categories][PackageCatagories] this package falls under:
2929
- [ ] Data retrieval
3030
- [ ] Data extraction
3131
- [ ] Data munging
@@ -35,7 +35,7 @@ Version accepted: TBD
3535
- [ ] Education
3636
- [ ] Data visualization*
3737

38-
\* Please fill out a pre-submission inquiry before submitting a data visualization package. For more info, see [this section](https://www.pyopensci.org/dev_guide/peer_review/aims_scope.html#notes-on-categories) of our guidebook.
38+
\* Please fill out a pre-submission inquiry before submitting a data visualization package. For more info, see [notes on categories][NotesOnCategories] of our guidebook.
3939

4040
- Explain how the and why the package falls under these categories (briefly, 1-2 sentences):
4141

@@ -47,10 +47,10 @@ Version accepted: TBD
4747

4848
## Technical checks
4949

50-
For details about the pyOpenSci packaging requirements, see our [packaging guide](https://www.pyopensci.org/dev_guide/packaging/packaging_guide.html). Confirm each of the following by checking the box. This package:
50+
For details about the pyOpenSci packaging requirements, see our [packaging guide][PackagingGuide]. Confirm each of the following by checking the box. This package:
5151

5252
- [ ] does not violate the Terms of Service of any service it interacts with.
53-
- [ ] has an [OSI approved license](https://opensource.org/licenses)
53+
- [ ] has an [OSI approved license][OsiApprovedLicense].
5454
- [ ] contains a README with instructions for installing the development version.
5555
- [ ] includes documentation with examples for all functions.
5656
- [ ] contains a vignette with examples of its essential functions and uses.
@@ -59,14 +59,14 @@ For details about the pyOpenSci packaging requirements, see our [packaging guide
5959

6060
## Publication options
6161

62-
- [ ] Do you wish to automatically submit to the [Journal of Open Source Software](http://joss.theoj.org/)? If so:
62+
- [ ] Do you wish to automatically submit to the [Journal of Open Source Software][JournalOfOpenSourceSoftware]? If so:
6363

6464
<details>
6565
<summary>JOSS Checks</summary>
6666

67-
- [ ] The package has an **obvious research application** according to JOSS's definition in their [submission requirements](https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements). Be aware that completing the pyOpenSci review process **does not** guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS.
68-
- [ ] The package is not a "minor utility" as defined by JOSS's [submission requirements](https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements): "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria.
69-
- [ ] The package contains a `paper.md` matching [JOSS's requirements](https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain) with a high-level description in the package root or in `inst/`.
67+
- [ ] The package has an **obvious research application** according to JOSS's definition in their [submission requirements][JossSubmissionRequirements]. Be aware that completing the pyOpenSci review process **does not** guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS.
68+
- [ ] The package is not a "minor utility" as defined by JOSS's [submission requirements][JossSubmissionRequirements]: "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria.
69+
- [ ] The package contains a `paper.md` matching [JOSS's requirements][JossPaperRequirements] with a high-level description in the package root or in `inst/`.
7070
- [ ] The package is deposited in a long-term repository with the DOI:
7171

7272
*Note: Do not submit your package separately to JOSS*
@@ -80,11 +80,34 @@ This option will allow reviewers to open smaller issues that can then be linked
8080

8181
## Code of conduct
8282

83-
- [ ] I agree to abide by [pyOpenSci's Code of Conduct](https://www.pyopensci.org/contributing-guide/peer_review/coc.html) during the review process and in maintaining my package should it be accepted.
83+
- [ ] I agree to abide by [pyOpenSci's Code of Conduct][PyOpenSciCodeOfConduct] during the review process and in maintaining my package should it be accepted.
8484

8585

86-
**P.S.** *Have feedback/comments about our review process? Leave a comment [here](https://github.com/pyOpenSci/governance/issues/8)*
86+
**P.S.** *Have feedback/comments about our review process? Leave a comment [here][Comments]
8787

8888
## Editor and Review Templates
8989

90-
[Editor and review templates can be found here](https://www.pyopensci.org/contributing-guide/appendices/templates.html)
90+
[Editor and review templates can be found here][Templates]
91+
92+
[PackagingGuide]: https://www.pyopensci.org/contributing-guide/authoring/index.html#packaging-guide
93+
94+
[PackageCatagories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#package-categories
95+
96+
[NotesOnCategories]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html?highlight=data#notes-on-categories
97+
98+
99+
[JournalOfOpenSourceSoftware]: http://joss.theoj.org/
100+
101+
[JossSubmissionRequirements]: https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements
102+
103+
[JossPaperRequirements]: https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain
104+
105+
[PyOpenSciCodeOfConduct]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/code-of-conduct.html?highlight=code%20conduct
106+
107+
[GovernanceIssues]: https://github.com/pyOpenSci/governance/issues/8
108+
109+
[OsiApprovedLicense]: https://opensource.org/licenses
110+
111+
[Templates]: https://www.pyopensci.org/contributing-guide/appendices/templates.html
112+
113+
[Comments]: https://github.com/pyOpenSci/governance/issues/8

README.md

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,28 @@
11
# pyOpenSci Software Peer Review
22

3-
This repo hosts the pyOpenSci review process. Packages contributed to pyOpenSci undergo an open peer-review by community reviewers.
3+
This repo hosts the pyOpenSci review process. Packages contributed to pyOpenSci undergo an open peer-review by community reviewers.
44

5-
If you are interested in submitting a package, check out our [guidebook](https://www.pyopensci.org/dev_guide/intro.html) for info about how to package your code and submit a request for review. For authors, the most important sections are the [scope of pyOpenSci](https://www.pyopensci.org/dev_guide/peer_review/aims_scope.html), the [author guide](https://www.pyopensci.org/dev_guide/peer_review/author_guide.html), and the [packaging guide](https://www.pyopensci.org/dev_guide/packaging/packaging_guide.html). For details about the exact timeline and process of peer-review, see [this section](https://www.pyopensci.org/dev_guide/peer_review/peer_review_proc.html).
5+
If you are interested in submitting a package, check out our [guidebook][Guidebook] for info about how to package your code and submit a request for review. For authors, the most important sections are the [scope of pyOpenSci][Scope], the [author guide][AuthorGuide], and the [
6+
packaging guide][PackagingGuide]. For details about the exact timeline and process of peer-review, see [peer review timeline][PeerReviewTimeline].
67

7-
When you are ready to submit for review, fill out the [Submission template](https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=&template=submit-software-for-review.md&title=).
8+
When you are ready to submit for review, fill out the [Submission template][SubmissionTemplate]
9+
.
810

9-
If your package is not yet fully-developed or you're not sure whether it fits within pyOpenSci's [scope](https://www.pyopensci.org/dev_guide/peer_review/aims_scope.html), you can create a [presubmission inquiry issue](https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=&template=presubmission-inquiry.md&title=).
11+
If your package is not yet fully-developed or you're not sure whether it fits within pyOpenSci's [
12+
scope][Scope], you can create a [presubmission inquiry issue][PresubmissionInquiryIssue].
13+
14+
[Guidebook]: https://www.pyopensci.org/contributing-guide/intro.html
15+
16+
[Scope]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/aims-and-scope.html
17+
18+
[AuthorGuide]: https://www.pyopensci.org/contributing-guide/authoring/index.html
19+
20+
[PackagingGuide]: https://www.pyopensci.org/contributing-guide/authoring/index.html#packaging-guide
21+
22+
[PeerReviewTimeline]: https://www.pyopensci.org/contributing-guide/open-source-software-peer-review/intro.html#the-peer-review-timeline
23+
24+
[SubmissionTemplate]: https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=&template=submit-software-for-review.md&title=
25+
26+
[PresubmissionInquiryIssue]: https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=&template=presubmission-inquiry.md&title=
1027

1128

0 commit comments

Comments
 (0)