Let the static playlist library depend on the static symbols of the projectM library #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kblaschke approved these changes Feb 14, 2025
Member
kblaschke left a comment
kblaschke left a comment There was a problem hiding this comment.
You're right, the object library should also have that definition set!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Situation: If you're compiling a program with CMake (on windows, using msys2) using BUILD_SHARED_LIBS=OFF, and your program/target depends on "libprojectM::playlist", then CMake will automatically add the static targets for "libprojectM::projectM". Without the changes in this PR, the linker may then complain about missing symbols like
__imp__projectm_set_preset_switch_requested_event_callback, as the export defines were not set to remove the declspec.This PR fixes compilation with static linking of the client to the projectM playlist library.