fix: parser test labels #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mertovun commented Apr 18, 2024
mertovun commented - swaps misordered label values
Member
| The tests are actually labeled correctly. There's a misleading comment in the first of the two test cases, which might give that impression. That should be deleted, but the tests should keep their respective names. |
kblaschke requested changes Apr 18, 2024
Member
kblaschke left a comment
kblaschke left a comment There was a problem hiding this comment.
Keep the labels as-is, but either remove or fix this comment:
kblaschke approved these changes Apr 18, 2024
Member
kblaschke left a comment
kblaschke left a comment There was a problem hiding this comment.
Thanks! Now it's both correct and no longer confusing 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.