v4.1.x - Build system fixes (Cherry-pick to master) #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kblaschke added bug kblaschke force-pushed the v4.1.x-dev/build-system-fixes branch 2 times, most recently from 0b42d70 to 7d40b96 Compare 
blaquewithaq approved these changes Mar 19, 2024
Also simplified it a bit, excluding the unnecessary source files and adding the interface library on the top level CMakeLists.txt.
Happens in the rare cases if a preset has no warp shader
kblaschke force-pushed the v4.1.x-dev/build-system-fixes branch from 7d40b96 to e538ccc Compare 
Member Author
| Rebased on master, as the ReadMe update made it necessary. Will also conveniently merge the emscripten pthreads fix with this one. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Exactly the same as the other PR, this will just be a fast-forward to the v4.1.x branch then.