Fix SimpleXMLElement issue

Author: ondrejmirtes

src/Type/ObjectType.php

@@ -696,7 +696,7 @@ public function getIterableKeyType(): Type
 }
 }
 
-if ($this->isInstanceOf(Traversable::class)->yes()) {
+if ($this->isInstanceOf(Traversable::class)->yes() && !$this->isExtraOffsetAccessibleClass()->yes()) {
 $isTraversable = true;
 $tKey = GenericTypeVariableResolver::getType($this, Traversable::class, 'TKey');
 if ($tKey !== null) {
@@ -732,7 +732,7 @@ public function getIterableValueType(): Type
 }
 }
 
-if ($this->isInstanceOf(Traversable::class)->yes()) {
+if ($this->isInstanceOf(Traversable::class)->yes() && !$this->isExtraOffsetAccessibleClass()->yes()) {
 $isTraversable = true;
 $tValue = GenericTypeVariableResolver::getType($this, Traversable::class, 'TValue');
 if ($tValue !== null) {

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -821,6 +821,7 @@ public function dataFileAsserts(): iterable
 yield from $this->gatherAssertTypes(__DIR__ . '/data/array-search-type-specifying.php');
 yield from $this->gatherAssertTypes(__DIR__ . '/data/array-replace.php');
 yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-6889.php');
+yield from $this->gatherAssertTypes(__DIR__ . '/data/simplexml.php');
 }
 
 /**

tests/PHPStan/Analyser/data/simplexml.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace SimpleXMLIteratorBug;
+
+use SimpleXMLElement;
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+public function getAddressByGps()
+{
+/** @var SimpleXMLElement|null $data */
+$data = doFoo();
+
+if ($data === null) {
+return;
+}
+
+assertType('(SimpleXMLElement|null)', $data->item);
+foreach ($data->item as $item) {
+assertType('SimpleXMLElement', $item);
+assertType('SimpleXMLElement|null', $item['name']);
+}
+}
+
+}
+
+class Bar extends SimpleXMLElement
+{
+
+public function getAddressByGps()
+{
+/** @var self|null $data */
+$data = doFoo();
+
+if ($data === null) {
+return;
+}
+
+assertType('(SimpleXMLIteratorBug\Bar|null)', $data->item);
+foreach ($data->item as $item) {
+assertType(self::class, $item);
+assertType('SimpleXMLIteratorBug\Bar|null', $item['name']);
+}
+}
+
+}
+
+class Baz
+{
+
+public function getAddressByGps()
+{
+/** @var Bar|null $data */
+$data = doFoo();
+
+if ($data === null) {
+return;
+}
+
+assertType('(SimpleXMLIteratorBug\Bar|null)', $data->item);
+foreach ($data->item as $item) {
+assertType(Bar::class, $item);
+assertType('SimpleXMLIteratorBug\Bar|null', $item['name']);
+}
+}
+
+}