Skip to content

Commit 2060a58

Browse files
author
Marcel Sauer
committed
minor fixes
1 parent 89610d0 commit 2060a58

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

src/main/java/de/marcelsauer/profiler/processor/AbstractAsyncStackProcessor.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public void process(RecordingEvent event) {
5959
@Override
6060
public void start() {
6161
logger.info("starting " + this.getClass().getName());
62-
addShutdownHook();
6362
startScheduler();
6463
doStart();
6564
}
@@ -92,15 +91,6 @@ public static int getSuccessfullyProcessedStacksCounter() {
9291
return successfullyProcessedStacksCounter.intValue();
9392
}
9493

95-
private void addShutdownHook() {
96-
Runtime.getRuntime().addShutdownHook(new Thread("jca-writer-shutdown-thread") {
97-
@Override
98-
public void run() {
99-
AbstractAsyncStackProcessor.this.stop();
100-
}
101-
});
102-
}
103-
10494
private void startScheduler() {
10595
scheduledExecutor.scheduleAtFixedRate(new WorkQueueProcessorTask(), 0, 1, TimeUnit.SECONDS);
10696
}

src/main/java/de/marcelsauer/profiler/processor/StackProcessorFactory.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,19 @@ public static StackProcessor getStackProcessor() {
2828
logger.info("using stack processor of type: " + stackProcessor.getClass().getName());
2929

3030
stackProcessor.start();
31+
32+
addShutdownHook();
33+
3134
return stackProcessor;
3235
}
36+
37+
private static void addShutdownHook() {
38+
Runtime.getRuntime().addShutdownHook(new Thread("jca-shutdown-thread") {
39+
@Override
40+
public void run() {
41+
logger.info("shutting down jca processor " + stackProcessor.getClass().getName());
42+
stackProcessor.stop();
43+
}
44+
});
45+
}
3346
}

src/main/java/de/marcelsauer/profiler/processor/file/AsyncFileWritingStackProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import de.marcelsauer.profiler.processor.RecordingEvent;
1717

1818
/**
19-
* writes data to configured fiel
19+
* writes data to configured file
2020
*/
2121
public class AsyncFileWritingStackProcessor extends AbstractAsyncStackProcessor {
2222

src/test/java/integration/AbtractAsyncIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
/**
1717
* assumes you've build the project via <pre>mvn clean package</pre> so that ./target/ contains the agent jar
1818
*/
19-
abstract class AbtractAsyncIntegrationTest {
19+
abstract class AbtractAsyncIntegrationTest {
2020

2121
@Test
2222
public void thatAsyncProcessorWorks() throws Exception {
@@ -63,7 +63,7 @@ private void randomSleep() {
6363
public boolean isTrue() {
6464
return expectedStackCount == AbstractAsyncStackProcessor.getSuccessfullyProcessedStacksCounter();
6565
}
66-
}, expectedStackCount).go();
66+
}, expectedStackCount * 3).go();
6767

6868
// give some more time ...
6969
Thread.sleep(2000);

0 commit comments

Comments
 (0)