webdriverio: throw proper errors from selectByAttribute/VisibleText

Author: romovs

packages/webdriverio/src/commands/element/selectByAttribute.js

@@ -50,6 +50,10 @@ export default async function selectByAttribute (attribute, value) {
  const normalized = `[normalize-space(@${attribute.trim()}) = "${value.trim()}"]`
  const optionElement = await this.findElementFromElement(this.elementId, 'xpath', `./option${normalized}|./optgroup/option${normalized}`)
 
+ if (optionElement && optionElement.error === 'no such element') {
+ throw new Error(`Option with attribute "${attribute}=${value}" not found.`)
+ }
+
  /**
  * select option
  */

packages/webdriverio/src/commands/element/selectByVisibleText.js

@@ -60,6 +60,10 @@ export default async function selectByVisibleText (text) {
 
  const optionElement = await this.findElementFromElement(this.elementId, 'xpath', selections.join('|'))
 
+ if (optionElement && optionElement.error === 'no such element') {
+ throw new Error(`Option with text "${text}" not found.`)
+ }
+
  /**
  * select option
  */

packages/webdriverio/tests/commands/element/selectByAttribute.test.js

@@ -46,4 +46,22 @@ describe('selectByAttribute test', () => {
  [ELEMENT_KEY]: 'some-sub-elem-321'
  })
  })
+
+ it('should throw if option is not found', async () => {
+ expect.hasAssertions()
+
+ const mockElem = {
+ selector: 'foobar2',
+ elementId: 'some-elem-123',
+ 'element-6066-11e4-a52e-4f735466cecf': 'some-elem-123',
+ findElementFromElement: jest.fn().mockReturnValue(Promise.resolve({ error: 'no such element' }))
+ }
+ mockElem.selectByAttribute = elem.selectByAttribute.bind(mockElem)
+
+ try {
+ await mockElem.selectByAttribute('value', 'non-existing-value')
+ } catch (e) {
+ expect(e.toString()).toBe('Error: Option with attribute "value=non-existing-value" not found.')
+ }
+ })
 })

packages/webdriverio/tests/commands/element/selectByVisibleText.test.js

@@ -106,4 +106,22 @@ describe('selectByVisibleText test', () => {
  [ELEMENT_KEY]: 'some-sub-elem-321'
  })
  })
+
+ it('should throw if option is not found', async () => {
+ expect.hasAssertions()
+
+ const mockElem = {
+ selector: 'foobar2',
+ elementId: 'some-elem-123',
+ 'element-6066-11e4-a52e-4f735466cecf': 'some-elem-123',
+ findElementFromElement: jest.fn().mockReturnValue(Promise.resolve({ error: 'no such element' }))
+ }
+ mockElem.selectByVisibleText = elem.selectByVisibleText.bind(mockElem)
+
+ try {
+ await mockElem.selectByVisibleText('non-existing-option')
+ } catch (e) {
+ expect(e.toString()).toBe('Error: Option with text "non-existing-option" not found.')
+ }
+ })
 })