Skip to content

Commit e122e32

Browse files
Remove ff dependency (webdriverio#4927)
* remove ff * make puppeteer-ff optionial so --no-optional can be used * removbe import, and require in laucnh function * Update packages/devtools/src/launcher.js Co-Authored-By: Christian Bromann <github@christian-bromann.com> * fix for unit tests Co-authored-by: Christian Bromann <github@christian-bromann.com>
1 parent 04eef21 commit e122e32

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/devtools/src/launcher.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { launch as launchChromeBrowser } from 'chrome-launcher'
22
import puppeteer from 'puppeteer-core'
3-
import puppeteerFirefox from 'puppeteer-firefox'
43
import logger from '@wdio/logger'
54

65
import { getPages } from './utils'
@@ -58,6 +57,7 @@ async function launchChrome (capabilities) {
5857
}
5958

6059
function launchFirefox (capabilities) {
60+
const puppeteerFirefox = require('puppeteer-firefox')
6161
const firefoxOptions = capabilities['moz:firefoxOptions'] || {}
6262
return puppeteerFirefox.launch({
6363
args: firefoxOptions.args || [],
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
export default {
1+
module.exports = {
22
launch: jest.fn()
33
}

0 commit comments

Comments
 (0)