Bump the manylinux image used by build_linux_packages.sh #4376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Our current manylinux image ships GCC 10, which has recently started failing to compile torch-mlir, see failing CI job: * https://github.com/llvm/torch-mlir-release/actions/runs/19329445043/job/55288631613). While there may be narrower fixes, the image we use is also quite dated, so updating it is a reasonable path.
Collaborator
| @hanhanW or @Groverkss is this ok ? |
sahas3 approved these changes Nov 13, 2025
| arch="$(uname -m)" | ||
| echo "Running on Arch: ${arch}" | ||
| # This needs to be a manylinux image so we can ship pip packages | ||
| TM_RELEASE_DOCKER_IMAGE="${TM_RELEASE_DOCKER_IMAGE:-quay.io/pypa/manylinux2014_${arch}}" |
Member
There was a problem hiding this comment.
LGTM, thanks for fixing this.
How did you figure out the failure was due to older gcc from the following log:
2025-11-13T11:59:47.0582094Z cmake config: cmake -DCMAKE_BUILD_TYPE=Release -DPython3_EXECUTABLE=/opt/python/cp310-cp310/bin/python -DPython3_FIND_VIRTUALENV=ONLY -DPython_EXECUTABLE=/opt/python/cp310-cp310/bin/python -DPython_FIND_VIRTUALENV=ONLY -DMLIR_ENABLE_BINDINGS_PYTHON=ON -DLLVM_TARGETS_TO_BUILD=host -DLLVM_ENABLE_ZSTD=OFF -DCMAKE_VISIBILITY_INLINES_HIDDEN=ON -DCMAKE_C_VISIBILITY_PRESET=hidden -DCMAKE_CXX_VISIBILITY_PRESET=hidden -DTORCH_MLIR_ENABLE_LTC=OFF -DTORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS=OFF -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_EXTERNAL_PROJECTS='torch-mlir' -DLLVM_EXTERNAL_TORCH_MLIR_SOURCE_DIR=/main_checkout/torch-mlir /main_checkout/torch-mlir/externals/llvm-project/llvm 2025-11-13T11:59:47.0584454Z cmake build: cmake --build . --config Release --target TorchMLIRPythonModules -- -j4 2025-11-13T11:59:47.0585279Z cmake workspace: /main_checkout/torch-mlir/setup_build/cmake_build 2025-11-13T11:59:47.0888556Z error: subprocess-exited-with-error 2025-11-13T11:59:47.0888835Z 2025-11-13T11:59:47.0889433Z × Building wheel for torch-mlir (pyproject.toml) did not run successfully. 2025-11-13T11:59:47.0889799Z │ exit code: 1 2025-11-13T11:59:47.0890026Z ╰─> No available output. 
Contributor
I'm not familiar with this. It looks okay to me as long as the package build is green. @ScottTodd would you like to chime in? |
Member
| Yes manylinux_2_28_x86_64 is fine to update to. I'm using it on several projects. See the list at https://github.com/pypa/manylinux |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Our current manylinux image ships GCC 10, which has recently started
failing to compile torch-mlir, see failing CI job:
While there may be narrower fixes, the image we use is also quite dated,
so updating it is a reasonable path.