refactor: refactor onData callback being called by useEffect

The `onSuccess` option has breaking changes in v4 and behaves differently resolves #67

Author: Katarina Anton

src/use-infinite-subscription.ts

@@ -199,13 +199,19 @@ export function useInfiniteSubscription<
  refetchOnMount: true,
  refetchOnWindowFocus: false,
  refetchOnReconnect: false,
- onSuccess: options.onData,
  onError: (error: TError) => {
  clearErrors();
  options.onError && options.onError(error);
  },
  });
 
+ useEffect(() => {
+ if (queryResult.isSuccess) {
+ options.onData?.(queryResult.data);
+ }
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ }, [queryResult.data]);
+
  useEffect(() => {
  return function cleanup() {
  // Fixes unsubscribe

src/use-subscription.ts

@@ -135,13 +135,19 @@ export function useSubscription<
  refetchOnMount: true,
  refetchOnWindowFocus: false,
  refetchOnReconnect: false,
- onSuccess: options.onData,
  onError: (error: TError) => {
  clearErrors();
  options.onError && options.onError(error);
  },
  });
 
+ useEffect(() => {
+ if (queryResult.isSuccess) {
+ options.onData?.(queryResult.data);
+ }
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ }, [queryResult.data]);
+
  useEffect(() => {
  return function cleanup() {
  // Fixes unsubscribe