Fix imports shared/source/helpers/{basic_math.h,registered_method_dispatcher.h}

[floffel]

Signed-off-by: Florian Minnecker florian.github@minnecker.com

The build failed when building on gentoo, unless the patches in this pull request are applied.

[JablonskiMateusz]

could you please reorder includes to keep alphabetical order?

diff --git a/shared/source/helpers/basic_math.h b/shared/source/helpers/basic_math.h index 6cc9c1e9aa..7eb6e0193c 100644 --- a/shared/source/helpers/basic_math.h +++ b/shared/source/helpers/basic_math.h @@ -12,8 +12,8 @@ #include <cmath> #include <cstdint> #include <cstdlib> -#include <stdio.h> #include <limits> +#include <stdio.h> namespace Math { diff --git a/shared/source/helpers/registered_method_dispatcher.h b/shared/source/helpers/registered_method_dispatcher.h index cb7a3cc0bf..9afc749b60 100644 --- a/shared/source/helpers/registered_method_dispatcher.h +++ b/shared/source/helpers/registered_method_dispatcher.h @@ -7,9 +7,9 @@ #pragma once +#include <cstddef> #include <cstdint> #include <functional> -#include <cstddef> namespace NEO { 

[floffel]

Sorry I missed that.

[JablonskiMateusz]

According to our contribution guidelines, every commit in PR should include signed-off-by tag in commit msg. Please update the commits.

[floffel]

Sorry, I'm still all new to this... Please let me know if there is anything else I can do.

[JablonskiMateusz]

Please remove non-ASCII characters from commit messages:
fix error: ‘size_t’ does not name a type
fix error: ‘numeric_limits’ is not a member of ‘std’

[JablonskiMateusz]

@floffel As this code change is trivial but there are still some minor linter issues, do you mind if I commit this change for you, keeping you as signed-off-by?

[floffel]

@floffel As this code change is trivial but there are still some minor linter issues, do you mind if I commit this change for you, keeping you as signed-off-by?

I wouldn't mind at all. You dont need to keep the signed-off-by.
Sorry for all the extra work.

[JablonskiMateusz]

Change merged within 113cef8