Add cl_intel_pci_bus_info extension #374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bashbaug reviewed Nov 9, 2020
Contributor
bashbaug left a comment
bashbaug left a comment There was a problem hiding this comment.
I didn't fully review the implementation of this feature, but the interface definitions look as I would expect them to look and we have reserved enum 0x410f for this extension.
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
zzdanowicz reviewed Nov 16, 2020
Contributor
zzdanowicz left a comment
zzdanowicz left a comment There was a problem hiding this comment.
In general code looks OK, but it misses ULTs. Please also answer Michal questions and comments
zzdanowicz reviewed Nov 17, 2020
zzdanowicz reviewed Apr 13, 2021
zzdanowicz reviewed Apr 13, 2021
zzdanowicz approved these changes Apr 13, 2021
Contributor
zzdanowicz left a comment
zzdanowicz left a comment There was a problem hiding this comment.
Code looks good, but not sure if automatic checks will allow it. Let give it a try.
zzdanowicz approved these changes Apr 14, 2021
zzdanowicz approved these changes Apr 15, 2021
zzdanowicz approved these changes Apr 16, 2021
| auto gdi = getGdi(); | ||
| UNRECOVERABLE_IF(gdi == nullptr); | ||
| | ||
| if (gdi->queryAdapterInfo(&queryAdapterInfo) == STATUS_SUCCESS) { |
Contributor
There was a problem hiding this comment.
this query seems to be redundant, IMO you can reuse adapterBDF from Wddm. See here as a reference for tests: https://github.com/intel/compute-runtime/blob/master/opencl/test/unit_test/windows/os_interface_tests.cpp#L31
Signed-off-by: Egor Suldin <egor.suldin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add the extension to obtain PCI bus information about an OpenCL device.
It will allow profiling tools like Intel VTune to attribute the profiling
data to the appropriate device. And this extension will especially useful
if two or more identical devices are installed in the system.
Signed-off-by: Egor Suldin egor.suldin@intel.com