fix: update batch connection to request api endpoint info from client #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: storage 
This was referenced Mar 11, 2021
Merged
Merged
Merged
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…googleapis#392) * bug: let Batch Connection request api endpoint info from Client * add unit test coverage Co-authored-by: Cathy Ouyang <cathyo@google.com>
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…googleapis#392) * bug: let Batch Connection request api endpoint info from Client * add unit test coverage Co-authored-by: Cathy Ouyang <cathyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instantiating a batch creates a new connection. Since api endpoint and client info were not requested from the client, the batch did not respect client api endpoint (STORAGE_EMULATOR_HOST). This PR updates the batch constructor to request api endpoint and client info from client.
Fixes #376