fix: correctly decode times without microseconds #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: storage 
Currently custom_time is not being decoded correctly if the value has a zero in the microseconds field. This fixes the issue for custom_time as well as elsewhere by replacing _datetime_to_rfc3339 with _rfc3339_nanos_to_datetime. Fixes googleapis#363
tritone force-pushed the customtime-micros branch from 0de2a21 to d2e1fc6 Compare tritone changed the title 
frankyn approved these changes Feb 9, 2021
tseaver added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
Contributor
Contributor
| Thanks @tseaver. Did we miss a coverage check? |
Contributor Author
The system test does cover the case that was failing before and ensures that we're correctly parsing the timestamp that GCS returns. I haven't dug into how this code is unit tested currently but I can look into it if you think it would help. |
andrewsg added the automerge 
gcf-merge-on-green bot removed the automerge This was referenced Mar 11, 2021
Merged
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Currently custom_time is not being decoded correctly if the value has a zero in the microseconds field. This fixes the issue for custom_time as well as elsewhere by replacing _datetime_to_rfc3339 with _rfc3339_nanos_to_datetime. Fixes googleapis#363
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Currently custom_time is not being decoded correctly if the value has a zero in the microseconds field. This fixes the issue for custom_time as well as elsewhere by replacing _datetime_to_rfc3339 with _rfc3339_nanos_to_datetime. Fixes googleapis#363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently custom_time is not being decoded correctly if the value
has a zero in the microseconds field. This fixes the issue for
custom_time as well as elsewhere by replacing _datetime_to_rfc3339
with _rfc3339_nanos_to_datetime.
Fixes #363