fix(storage): add projection parameter to blob.reload method #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
frankyn suggested changes May 14, 2020
Contributor
frankyn left a comment
frankyn left a comment There was a problem hiding this comment.
Please add a system test. Otherwise LGTM
frankyn suggested changes May 15, 2020
Contributor
frankyn left a comment
frankyn left a comment There was a problem hiding this comment.
Thank you, have one last nit.
google/cloud/storage/_helpers.py Outdated
| | ||
| def reload( | ||
| self, | ||
| projection="noAcl", |
Contributor
There was a problem hiding this comment.
Can you move this parameter after the client parameter?
frankyn approved these changes May 15, 2020
IlyaFaer pushed a commit to MaxxleLLC/python-storage that referenced this pull request May 20, 2020
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #136