feat: add offset and includeTrailingPrefix options to list_blobs #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
frankyn suggested changes May 4, 2020
| blobs = list(page) | ||
| self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"]) | ||
| self.assertIsNone(iterator.next_page_token) | ||
| self.assertEqual(iterator.prefixes, set(["parent/"])) |
Contributor
There was a problem hiding this comment.
how is this request different when include_trailinig_delimitier=False? I don't see the difference between the system test in this case.
Contributor Author
There was a problem hiding this comment.
The difference is that this is the only name that includes parent/ in self.assertEqual([blob.name for blob in blobs], ["file01.txt", "parent/"]).
Contributor Author
There was a problem hiding this comment.
I'll leave this for you to resolve if you're satisfied with that explanation
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…gleapis#125) * feat: add offset and includeTrailingPrefix options to list_blobs * lint * fix comment typo in system tests Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…gleapis#125) * feat: add offset and includeTrailingPrefix options to list_blobs * lint * fix comment typo in system tests Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.