Skip to content

feat: add support for NUMERIC type #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 3, 2020
Merged

feat: add support for NUMERIC type #86

merged 9 commits into from
Sep 3, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented May 15, 2020

No description provided.

@larkee larkee added api: spanner Issues related to the googleapis/python-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 15, 2020
@larkee larkee requested a review from skuruppu May 15, 2020 03:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@larkee larkee force-pushed the numeric-support branch from a6cf8a2 to 194ec3c Compare July 2, 2020 08:09
@larkee larkee force-pushed the numeric-support branch from 194ec3c to 1accf1f Compare July 16, 2020 05:54
@skuruppu skuruppu requested a review from hengfengli July 23, 2020 05:03
hengfengli
hengfengli reviewed Jul 23, 2020
View reviewed changes
hengfengli
hengfengli approved these changes Jul 23, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@larkee larkee requested a review from a team as a code owner September 3, 2020 03:33
hengfengli
hengfengli reviewed Sep 3, 2020
View reviewed changes
hengfengli
hengfengli approved these changes Sep 3, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@larkee larkee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 3, 2020
@larkee larkee merged commit a79786e into googleapis:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

5 participants

@larkee @hengfengli @skuruppu @googlebot @yoshi-kokoro