Skip to content

fix: Django and SQLAlchemy APIs are failing to use rowcount #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2022
Merged

fix: Django and SQLAlchemy APIs are failing to use rowcount #654

merged 3 commits into from
Jan 6, 2022

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Dec 24, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Dec 24, 2021
@IlyaFaer IlyaFaer requested review from larkee and skuruppu December 24, 2021 10:40
@IlyaFaer IlyaFaer marked this pull request as ready for review December 24, 2021 10:40
@IlyaFaer IlyaFaer requested review from a team as code owners December 24, 2021 10:40
@skuruppu skuruppu requested a review from vi3k6i5 December 29, 2021 06:31
vi3k6i5
vi3k6i5 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will fix a lot of open issues in django and SQLAlchemy.
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@vi3k6i5 vi3k6i5 merged commit 698260e into googleapis:main Jan 6, 2022
@IlyaFaer IlyaFaer deleted the rowcount branch January 6, 2022 07:55
vi3k6i5 added a commit to vi3k6i5/python-spanner that referenced this pull request Mar 29, 2022
@vi3k6i5
fix: Django and SQLAlchemy APIs are failing to use rowcount (googleap…
8758bf8 
…is#654) * fix: Django and SQLAlchemy APIs are failing to use rowcount * lint fix Co-authored-by: Vikash Singh <3116482+vi3k6i5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

3 participants

@IlyaFaer @vi3k6i5 @yoshi-kokoro