Skip to content

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Sep 21, 2021

Based on #475 and requires it to be merged first.

IlyaFaer and others added 30 commits August 2, 2021 12:42
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@larkee larkee requested a review from a team as a code owner November 1, 2021 00:32
@skuruppu
Copy link
Contributor

skuruppu commented Nov 9, 2021

@IlyaFaer what do we need to do to get this merged? Are the test failures related to this change or are they flaky?

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2021
@IlyaFaer
Copy link
Contributor Author

@skuruppu, looks like there was a problem with lint (I've updated the black linting package locally, but kokoro seems to be using a particular version). Fixed it, let's see if everything is okay now.

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2021
@IlyaFaer IlyaFaer merged commit 8ca868c into googleapis:main Nov 13, 2021
@IlyaFaer IlyaFaer deleted the stale_reads branch November 13, 2021 08:50
asthamohta pushed a commit to asthamohta/python-spanner that referenced this pull request Nov 16, 2021
asthamohta pushed a commit to asthamohta/python-spanner that referenced this pull request Nov 16, 2021
asthamohta pushed a commit to asthamohta/python-spanner that referenced this pull request Nov 16, 2021
vi3k6i5 pushed a commit that referenced this pull request Dec 21, 2021
* chore: changing default region to us-west1 * chore(deps): update all dependencies (#602) * chore: add default_version and codeowner_team to .repo-metadata.json (#641) * feat(db_api): support stale reads (#584) * feat: removing changes from samples * chore: change region * fix: fix in sample list-backups Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Ilya Gurov <ilya.faer@mail.ru> Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
vi3k6i5 pushed a commit to vi3k6i5/python-spanner that referenced this pull request Mar 29, 2022
* chore: changing default region to us-west1 * chore(deps): update all dependencies (googleapis#602) * chore: add default_version and codeowner_team to .repo-metadata.json (googleapis#641) * feat(db_api): support stale reads (googleapis#584) * feat: removing changes from samples * chore: change region * fix: fix in sample list-backups Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Ilya Gurov <ilya.faer@mail.ru> Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

4 participants