fix(db_api): update parse_util output for homogeneous statements #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: spanner 
larkee reviewed Feb 15, 2021
| "table": match.group("table_name"), | ||
| "columns": columns, | ||
| "values": rows_list, | ||
| } |
There was a problem hiding this comment.
Nope i think.
There was a problem hiding this comment.
Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.
| Please update the title to be more descriptive i.e. The PR title will be used in the release notes. |
HemangChothani changed the title larkee reviewed Feb 15, 2021
| "table": match.group("table_name"), | ||
| "columns": columns, | ||
| "values": rows_list, | ||
| } |
There was a problem hiding this comment.
Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.
I have changed the title. |
larkee approved these changes Feb 16, 2021
larkee changed the title IlyaFaer pushed a commit to MaxxleLLC/python-spanner that referenced this pull request Mar 22, 2021
larkee pushed a commit that referenced this pull request Mar 24, 2021
* fix: revert #233 * update docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #232